Microtask 5 #5
Open
Microtask 5 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgr
reviewed
Nov 9, 2017
| username = request.POST['username'] | ||
| try: | ||
| if not username: | ||
| raise Error("Please enter a username") |
There was a problem hiding this comment.
This should be Exception, not Error (I probably remembered wrong). Or you can define your own error type (that has the benefit that you can let other types bubble up to the framework and it will probably show a more developer-friendly error message, with stack traces and whatnot).
| url_base = 'https://en.wikipedia.org/w/api.php?' | ||
| # Recieved data in json-format | ||
| response = requests.get(url_base, params = params) | ||
| if response.status_code == 200: |
There was a problem hiding this comment.
You can use response.raise_for_status() and let exception handling deal with non-200 responses.
| # Recieved data in json-format | ||
| response = requests.get(url_base, params = params) | ||
| if response.status_code == 200: | ||
| edits_data = json.loads(response.text) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tgr
Sir,
This tool provides view count of last five edits of user in English wiki in current year.
Tool- link
Please review.
Thank you.